Skip to content

gh-115119: defer removal of bundled libmpdec to 3.16 #133997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

gh-115119: defer removal of bundled libmpdec to 3.16 #133997

wants to merge 6 commits into from

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented May 14, 2025 •
edited by github-actions bot
Loading

@skirpichev skirpichev requested a review from AA-Turner May 14, 2025 11:00
@skirpichev skirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 14, 2025
@bedevere-app bedevere-app bot added the docs Documentation in the Doc dir label May 14, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 14, 2025
Open
15 tasks
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs May 14, 2025
StanFromIreland
StanFromIreland reviewed May 14, 2025
View reviewed changes
@skirpichev skirpichev requested a review from hugovk May 15, 2025 06:47
@skirpichev
Copy link
Contributor Author

Oops, this seems to be not just a docs patch. I hope this still ok for backport.

@skirpichev skirpichev mentioned this pull request May 16, 2025
Open
@skirpichev skirpichev requested a review from vstinner May 30, 2025 05:41
@skirpichev skirpichev requested a review from picnixz June 2, 2025 03:24
picnixz
picnixz reviewed Jun 2, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to say but I'm neutral on delaying the removal.

@hugovk hugovk removed their request for review June 2, 2025 11:06
@vstinner
Copy link
Member

vstinner commented Jun 2, 2025

defer removal of bundled libmpdec to 3.16

What is the rationale for defering the removal?

@skirpichev
Copy link
Contributor Author

What is the rationale for defering the removal?

You can see the issue thread.

For my humble opinion the only excuse is that we miss removal of the implicit fallback to bundled copy (now #134078) in 3.14. (Though, this wasn't announced somewhere else.) We also miss libmpdec in latest ubuntu images. (I think this will be solved before 3.14 release.)

@AA-Turner
Copy link
Member

For my humble opinion the only excuse is that we miss removal of the implicit fallback to bundled copy

I still think we can stick to the original plan (that is: remove the vendored copy in 3.15). The only issue to solve is installing development sources on Ubuntu for 24.04.

@skirpichev
Copy link
Contributor Author

FYI, I restored removal PR: #133964. I think libmpdec can be installed from PPA for PHP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@vstinner vstinner Awaiting requested review from vstinner

@picnixz picnixz Awaiting requested review from picnixz

Assignees
No one assigned
Labels
awaiting core review docs Documentation in the Doc dir needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news
Projects
Docs PRs
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skirpichev @vstinner @AA-Turner @picnixz @StanFromIreland