-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
[3.14] gh-134060: Don't create a certain symlink in venv
if platform does not support it
#134061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Running |
Maybe @serhiy-storchaka is interested since you are working on similar instances. |
!buildbot rasbian |
The regex 'rasbian' did not match any buildbot builder. Is the requested builder in the list of stable builders? |
!buildbot raspbian |
🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit 41af4a9 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134061%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Before:
After (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This seems reasonable to me and it looks like PEP 529 means it will work on Windows as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Anything else left to do here? |
Should this get a NEWS since it is a sensitive topic?
I think just checking for utf8 is simplest and will cover most platforms, rather than complicated methods for an easter egg symlink (It's not worth it IMO).
Request @hugovk @hauntsaninja
3.14
when system encoding is not utf-8 #134060