Skip to content

[3.14] gh-134060: Don't create a certain symlink in venv if platform does not support it #134061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented May 15, 2025

Should this get a NEWS since it is a sensitive topic?

I think just checking for utf8 is simplest and will cover most platforms, rather than complicated methods for an easter egg symlink (It's not worth it IMO).

Request @hugovk @hauntsaninja

@StanFromIreland
Copy link
Contributor Author

StanFromIreland commented May 15, 2025

Running !buildbot rasbian (!buildbot ARM64 Raspbian should in theory call the exact one we want, but might be dangerous as it may call all ARM64 buildbots?) will confirm the fix.

@StanFromIreland
Copy link
Contributor Author

Maybe @serhiy-storchaka is interested since you are working on similar instances.

@ZeroIntensity
Copy link
Member

!buildbot rasbian

@bedevere-bot
Copy link

The regex 'rasbian' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@ZeroIntensity
Copy link
Member

!buildbot raspbian

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit 41af4a9 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134061%2Fmerge

The command will test the builders whose names match following regular expression: raspbian

The builders matched are:

  • ARM Raspbian PR
  • ARM64 Raspbian PR

@StanFromIreland
Copy link
Contributor Author

Before:

9 tests failed:
    test_cext test_cppext test_httpservers test_peg_generator
    test_strftime test_strptime test_sysconfig test_time test_venv
461 tests OK.

After (str[p,f]time, time unrelated, I changed the config):

1 test failed:
    test_httpservers
469 tests OK.

Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This seems reasonable to me and it looks like PEP 529 means it will work on Windows as well

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@StanFromIreland
Copy link
Contributor Author

Anything else left to do here?

@serhiy-storchaka serhiy-storchaka merged commit 91d71ac into python:3.14 May 18, 2025
49 of 50 checks passed
@StanFromIreland StanFromIreland deleted the fixnoteasteregg branch May 18, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants