Skip to content

gh-133374: fix test_python_legacy_windows_stdio #134080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2025
Merged

gh-133374: fix test_python_legacy_windows_stdio #134080

merged 2 commits into from
May 20, 2025

Conversation

methane
Copy link
Member

@methane methane commented May 16, 2025 •
edited by bedevere-app bot
Loading

@methane methane requested review from zooba and a team May 16, 2025 07:16
@methane methane mentioned this pull request May 16, 2025
Open
@chris-eibl
Copy link
Member

See also #133375.

zooba
zooba reviewed May 16, 2025
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is closer to being ready than the other PR, IMHO. So up to the two contributors to see who gets there first :)

@methane methane changed the title fix test_python_legacy_windows_stdio gh-133374: fix test_python_legacy_windows_stdio May 16, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 16, 2025
Closed
@methane
Copy link
Member Author

methane commented May 16, 2025

Should we use creationflags=subprocess.CREATE_NEW_CONSOLE only when not os.isatty(sys.stdin)?

When a Windows developer runs a test on the console, will a new annoying console appear for a moment? (I cannot run test on Windows Desktop soon.)

@zooba
Copy link
Member

zooba commented May 19, 2025

When a Windows developer runs a test on the console, will a new annoying console appear for a moment?

It will, but don't we have a resource for this already?

If the new console doesn't appear, annoying characters get typed over the test results for some similar tests. So I'm pretty sure they're all behind a resource.

@methane methane merged commit 652d693 into python:main May 20, 2025
44 checks passed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 20, 2025
@miss-islington-app
Copy link

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry, @methane, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 652d6938ef8c42c1c4c180c3f0e257c26c6677da 3.13

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@methane @miss-islington
pythongh-133374: fix test_python_legacy_windows_stdio (pythonGH-134080)
c95962a 
(cherry picked from commit 652d693)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2025

GH-134314 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.13 bugs and security fixes label May 20, 2025
serhiy-storchaka pushed a commit that referenced this pull request May 20, 2025
@miss-islington @methane
[3.14] gh-133374: fix test_python_legacy_windows_stdio (GH-134080) (G…
90aa13a 
…H-134314)

(cherry picked from commit 652d693)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

Assignees

@methane methane

Labels
OS-windows skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@methane @chris-eibl @zooba @serhiy-storchaka