Skip to content

gh-133890: Handle UnicodeEncodeError in tarfile #134147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2025
Merged

gh-133890: Handle UnicodeEncodeError in tarfile #134147

merged 3 commits into from
May 18, 2025

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 17, 2025 •
edited by bedevere-app bot
Loading

UnicodeEncodeError is now handled the same way as OSError during TarFile member extraction.

@serhiy-storchaka
pythongh-133890: Handle UnicodeEncodeError in tarfile
6772f2d 
UnicodeEncodeError is now handled the same way as OSError during
TarFile member extraction.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 17, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 17, 2025
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 18, 2025
Open
@serhiy-storchaka serhiy-storchaka merged commit 9983c7d into python:main May 18, 2025
39 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2025
@serhiy-storchaka @miss-islington
pythongh-133890: Handle UnicodeEncodeError in tarfile (pythonGH-134147)
f2184e3 
UnicodeEncodeError is now handled the same way as OSError during
TarFile member extraction.
(cherry picked from commit 9983c7d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9983c7d4416cac8deb2fded1ec9c7daf786c3a02 3.13

@serhiy-storchaka serhiy-storchaka deleted the tarfile-filter-unencodable branch May 18, 2025 19:21
@bedevere-app
Copy link

bedevere-app bot commented May 18, 2025

GH-134195 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 18, 2025
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 18, 2025
@serhiy-storchaka
[3.13] pythongh-133890: Handle UnicodeEncodeError in tarfile (pythonG…
5d07c55 
…H-134147)

UnicodeEncodeError is now handled the same way as OSError during
TarFile member extraction.
(cherry picked from commit 9983c7d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 18, 2025

GH-134196 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 18, 2025
serhiy-storchaka added a commit that referenced this pull request May 19, 2025
@serhiy-storchaka
[3.13] gh-133890: Handle UnicodeEncodeError in tarfile (GH-134147) (G…
06a8c06 
…H-134196)

UnicodeEncodeError is now handled the same way as OSError during
TarFile member extraction.
(cherry picked from commit 9983c7d)
serhiy-storchaka added a commit that referenced this pull request May 20, 2025
@miss-islington @serhiy-storchaka
[3.14] gh-133890: Handle UnicodeEncodeError in tarfile (GH-134147) (G…
c23bdc2 
…H-134195)

UnicodeEncodeError is now handled the same way as OSError during
TarFile member extraction.
(cherry picked from commit 9983c7d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@serhiy-storchaka