Skip to content

gh-134291: Add unguarded-availability check to JIT builds #134292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

gh-134291: Add unguarded-availability check to JIT builds #134292

wants to merge 1 commit into from

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented May 19, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 19, 2025
Open
@zanieb
Copy link
Contributor Author

zanieb commented May 19, 2025

In https://github.com/python/cpython/actions/runs/15123945496/job/42512754979?pr=134292, you can see this fails "as intended" because a symbol requiring 11+ is used. This pull request will need to be merged after a guard is added for that symbol (or, its use is removed entirely).

@zanieb zanieb added the infra CI, GitHub Actions, buildbots, Dependabot, etc. label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher will be requested when the pull request is marked ready for review brandtbucher is a code owner

@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski will be requested when the pull request is marked ready for review savannahostrowski is a code owner

Assignees

@brandtbucher brandtbucher

Labels
infra CI, GitHub Actions, buildbots, Dependabot, etc. skip news topic-JIT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanieb @brandtbucher