GH-131798: Optimize cached class attributes and methods in the JIT #134403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| // The cached value may be dead, so we need to do the lookup again... :( | ||
| if (type && PyType_Check(type)) { | ||
| PyObject *lookup = _PyType_Lookup(type, name); |
There was a problem hiding this comment.
Well this is sad, I would've hoped pure would be able to handle this. But yeah we need to look up again.
tomasr8
approved these changes
May 21, 2025
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles
_LOAD_ATTR_CLASS,_LOAD_ATTR_NONDESCRIPTOR_WITH_VALUES,_LOAD_ATTR_NONDESCRIPTOR_NO_DICT,_LOAD_ATTR_METHOD_WITH_VALUES,_LOAD_ATTR_METHOD_NO_DICT, and_LOAD_ATTR_METHOD_LAZY_DICT.Also: clean up a few things I ran into while working on this, and document our symbol lattice.