gh-134455: Fix build-details.json to use the c_api.headers key
#134456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` key Fix `build-details.json` generation to use the correct `c_api.headers` key as defined in PEP 739, instead of `c_api.include`.
|
CC @FFY00 |
|
Apparently the standalone tool has the same problem, and someone already submitted a fix for it: FFY00/python-introspection#2 |
FFY00
approved these changes
May 22, 2025
Yeah, that's the origin of the code I merged into CPython, so it tracks 😅 |
|
And backport to 3.14? |
|
Ah, yes, I was forgetting we already branched out. Thanks for the reminder @hugovk! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 22, 2025
…` key (pythonGH-134456) Fix `build-details.json` generation to use the correct `c_api.headers` key as defined in PEP 739, instead of `c_api.include`. (cherry picked from commit d706eb9) Co-authored-by: Michał Górny <mgorny@gentoo.org> Co-authored-by: Filipe Laíns 🇵🇸 <lains@riseup.net>
|
GH-134504 is a backport of this pull request to the 3.14 branch. |
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
May 26, 2025
…` key (python#134456) Fix `build-details.json` generation to use the correct `c_api.headers` key as defined in PEP 739, instead of `c_api.include`. Co-authored-by: Filipe Laíns 🇵🇸 <lains@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
build-details.jsongeneration to use the correctc_api.headerskey as defined in PEP 739, instead ofc_api.include.build-details.json:c_api.includeis used instead ofc_api.headers#134455