Skip to content

gh-91048: Add better error messages for remote debugging for CI builds #134682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented May 26, 2025

@pablogsal
Copy link
Member Author

pablogsal commented May 26, 2025

These only trigger in the test suite mode and are mainly to help diagnose errors in CI in the future

@pablogsal pablogsal force-pushed the better_errors branch 3 times, most recently from 9d3c02d to 2a13bc5 Compare May 26, 2025 01:25
@pablogsal
Copy link
Member Author

pablogsal commented May 26, 2025

Example chain:

RuntimeError: mach_vm_read_overwrite failed for PID 74282 at address 0x1 (size 216): kern_return_t 1

The above exception was the direct cause of the following exception:

RuntimeError: Failed to read code object

The above exception was the direct cause of the following exception:

RuntimeError: Failed to parse frame object in chain

The above exception was the direct cause of the following exception:

RuntimeError: Failed to process frame chain

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/pablogsal/github/python/main/benchmark_get_stack_trace.py", line 189, in benchmark
    stack_trace = unwinder.get_stack_trace()
RuntimeError: Failed to unwind stack for thread

@pablogsal pablogsal force-pushed the better_errors branch 7 times, most recently from 6b35763 to a15c91e Compare May 26, 2025 02:09
@pablogsal pablogsal enabled auto-merge (squash) May 26, 2025 02:09
@pablogsal pablogsal force-pushed the better_errors branch 3 times, most recently from 1a97fe4 to 69ad823 Compare May 26, 2025 02:13
@pablogsal pablogsal changed the title gh-91048: Add better error messages for remote debugging in debug versions gh-91048: Add better error messages for remote debugging for CI builds May 26, 2025
@pablogsal pablogsal force-pushed the better_errors branch 3 times, most recently from ac5b598 to b90ef14 Compare May 26, 2025 03:07
@pablogsal pablogsal disabled auto-merge May 26, 2025 03:35
@pablogsal pablogsal force-pushed the better_errors branch 4 times, most recently from e8bb64b to 2b67d04 Compare May 26, 2025 13:35
…ug versions

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@pablogsal pablogsal merged commit 0909d6d into python:main May 26, 2025
38 checks passed
@pablogsal pablogsal deleted the better_errors branch May 26, 2025 14:31
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2025
… builds (pythonGH-134682)

(cherry picked from commit 0909d6d)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 26, 2025

GH-134719 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 26, 2025
pablogsal added a commit to miss-islington/cpython that referenced this pull request May 26, 2025
… builds (pythonGH-134682)

(cherry picked from commit 0909d6d)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant