[3.14] gh-91048: Correct Apple platform includes for iOS. (GH-134712) #134714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 26, 2025
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 25493d3 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134714%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
freakboy3742
approved these changes
May 26, 2025
mhsmith
reviewed
May 26, 2025
| @@ -35,7 +35,7 @@ extern "C" { | |||
| # include <sys/mman.h> | |||
| #endif | |||
|
|
|||
| #if defined(__APPLE__) && TARGET_OS_OSX | |||
| #if defined(__APPLE__) && defined(TARGET_OS_OSX) && TARGET_OS_OSX | |||
There was a problem hiding this comment.
For future reference, this is unnecessary, as undefined preprocessor symbols are always treated as if they have the value 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct Apple platform includes for iOS.
(cherry picked from commit 965662e)
Co-authored-by: Russell Keith-Magee russell@keith-magee.com