Skip to content

[3.14] gh-133968: Add PyUnicodeWriter_WriteASCII() function (#133973) #134974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

[3.14] gh-133968: Add PyUnicodeWriter_WriteASCII() function (#133973) #134974

merged 1 commit into from
Jun 9, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 31, 2025 •
edited
Loading

Replace most PyUnicodeWriter_WriteUTF8() calls with PyUnicodeWriter_WriteASCII().

(cherry picked from commit f49a07b)

📚 Documentation preview 📚: https://cpython-previews--134974.org.readthedocs.build/

@bedevere-app bedevere-app bot mentioned this pull request May 31, 2025
Closed
@bedevere-app bedevere-app bot mentioned this pull request May 31, 2025
Merged
@vstinner
Copy link
Member Author

@hugovk: Hi, can I have an exception to add this late feature into Python 3.14 after the feature freeze? It was decided late but it comes with the PyUnicodeWriter which was just added to Python 3.14.

This change fix also a performance regression compared to Python 3.13: Using the public PyUnicodeWriter C API made the json module slower.

@zooba wrote:

I'd check with the RM about adding it to 3.14 as well. I suspect it should be okay - there's no compatibility impact, and it'll save introducing one by having to choose a different API between 3.14/3.15.

@vstinner vstinner mentioned this pull request May 31, 2025
Closed
6 tasks
@picnixz picnixz removed their request for review June 2, 2025 09:47
@vstinner @ZeroIntensity @picnixz
pythongh-133968: Add PyUnicodeWriter_WriteASCII() function (python#13…
39506d1 
…3973)

Replace most PyUnicodeWriter_WriteUTF8() calls with
PyUnicodeWriter_WriteASCII().

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
(cherry picked from commit f49a07b)
@vstinner
Copy link
Member Author

vstinner commented Jun 2, 2025

I used git push --force to remove this change from the PR and the commit message:

Unrelated change to please the linter: remove an unused import in test_ctypes.

@vstinner
Copy link
Member Author

vstinner commented Jun 5, 2025

Ping @hugovk.

@hugovk
Copy link
Member

hugovk commented Jun 9, 2025

This is okay for 3.14.

hugovk
hugovk reviewed Jun 9, 2025
View reviewed changes
Doc/c-api/unicode.rst
On success, return ``0``.
On error, set an exception, leave the writer unchanged, and return ``-1``.

.. versionadded:: next
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need updating in main to 3.14.

@vstinner vstinner merged commit 3d69d18 into python:3.14 Jun 9, 2025
41 checks passed
@vstinner vstinner deleted the write_ascii14 branch June 9, 2025 12:37
@vstinner
Copy link
Member Author

vstinner commented Jun 9, 2025 •
edited
Loading

Follow-up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

@Eclips4 Eclips4 Awaiting requested review from Eclips4 Eclips4 is a code owner

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @hugovk