Skip to content

gh-134280: Disable constant folding for ~ with a boolean argument #134982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −0
Open

gh-134280: Disable constant folding for ~ with a boolean argument #134982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
deb1724
gh-134280: Disable constant folding for ~ with a boolean argument
serhiy-storchaka May 31, 2025
ac03563
Merge branch 'main' into constant-folding-invert-bool
serhiy-storchaka Jun 10, 2025
cb7d754
Add a comment about the temporary nature of the code.
serhiy-storchaka Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/test/test_peepholer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ def test_constant_folding_unaryop(self):
('---x', 'UNARY_NEGATIVE', None, False, None, None),
('~~~x', 'UNARY_INVERT', None, False, None, None),
('+++x', 'CALL_INTRINSIC_1', intrinsic_positive, False, None, None),
('~True', 'UNARY_INVERT', None, False, None, None),
]

for (
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-05-31-19-24-54.gh-issue-134280.NDVbzY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Disable constant folding for ``~`` with a boolean argument.
This moves the deprecation warning from compile time to runtime.
4 changes: 4 additions & 0 deletions Python/flowgraph.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1892,6 +1892,10 @@ eval_const_unaryop(PyObject *operand, int opcode, int oparg)
result = PyNumber_Negative(operand);
break;
case UNARY_INVERT:
// XXX: This should be removed once the ~bool depreciation expires.
if (PyBool_Check(operand)) {
return NULL;
}
result = PyNumber_Invert(operand);
break;
case UNARY_NOT: {
Expand Down
Loading