gh-134953: Expand theming for True/False/None
#135000
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
commented
Jun 1, 2025
| @@ -176,6 +176,7 @@ class Argparse(ThemeSection): | |||
| class Syntax(ThemeSection): | |||
| prompt: str = ANSIColors.BOLD_MAGENTA | |||
| keyword: str = ANSIColors.BOLD_BLUE | |||
| keyword_constant: str = ANSIColors.BOLD_BLUE | |||
There was a problem hiding this comment.
And so the question is, do we want to change this for pyrepl?
There was a problem hiding this comment.
I agree with the issue OP that the is None in particular being in the same color looks strange.
There was a problem hiding this comment.
It could default to ANSIColors.CYAN, since True, False, and None would then be the same color as all the built-ins.
treyhunner
reviewed
Jun 1, 2025
| @@ -0,0 +1,2 @@ | |||
| Expand ``_colorize`` theme with ``keyword_colorize`` and implement in | |||
There was a problem hiding this comment.
I think keyword_colorize was meant to be keyword_constant here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not a fan of
constant, but it seems to be what Pypygments and Magicpython uses so I guess it is best?As for the other parts of the proposal in the issue I am not as big a fan, but I think this one is fine, and something I myself am used to in editors.