Skip to content

parser_generator.py typo - keywods -> keywords #135014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

parser_generator.py typo - keywods -> keywords #135014

wants to merge 2 commits into from

Conversation

chemelnucfin
Copy link

Pull Request title

Trivial changes, like fixing a typo, do not need an issue.

Typo in comment

@python-cla-bot
Copy link

python-cla-bot bot commented Jun 2, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jun 2, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

auvipy
auvipy approved these changes Jun 2, 2025
View reviewed changes
Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right work, but you also need to sign the cla and use skipnews

@bedevere-app
Copy link

bedevere-app bot commented Jun 2, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@chemelnucfin
Copy link
Author

right work, but you also need to sign the cla and use skipnews

I believe skipnews should be added by maintainers? I signed the cla.

Should I keep updating the branch or can someone just merge this trivial PR? Thanks.

@johnzhou721
Copy link
Contributor

johnzhou721 commented Jun 3, 2025 •
edited
Loading

Need someone to apply skip news and skip issue. Merging main into the branch or rebasing on top of main doesn't do harm but is unnessacary.

*EDIT-- as long as there are no conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

@Wulian233 Wulian233 Wulian233 approved these changes

@johnzhou721 johnzhou721 johnzhou721 approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chemelnucfin @johnzhou721 @auvipy @Wulian233