gh-131798: JIT: Optimize _CALL_TYPE_1 when the result is known
#135194
+34
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fidget-Spinner
approved these changes
Jun 6, 2025
|
The test failures should be fixed by #135204, let me update main to make sure CI is all green :) |
brandtbucher
approved these changes
Jun 6, 2025
| @@ -1806,7 +1826,6 @@ def testfunc(n): | |||
| self.assertEqual(res, TIER2_THRESHOLD) | |||
| self.assertIsNotNone(ex) | |||
| uops = get_opnames(ex) | |||
| self.assertIn("_CALL_TYPE_1", uops) | |||
There was a problem hiding this comment.
Super cool when older tests like this "break" with a new optimization. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #134369 (comment)
This completely removes
_CALL_TYPE_1when the abstract interpreter is able to deduce the result (by knowing the type of the argument).For example, for something like
type(42), we currently doNote that we still do the call even when we know the result.
In this PR, when the result is known,
_CALL_TYPE_1is replaced with_POP_CALL_ONE_LOAD_CONST_INLINE_BORROW:Thanks to some previous work on optimizing
remove_unneeded_uopsthis becomes just:that is, the entire call is replaced with a load.