@picnixz I want to be sure that tstate does not change between these calls, because we can see that some other parts of this code changes tstate. So, maybe it is not safe to inline these calls like that? Let's be extra careful and use #ifdef instead 🤔

I want to be sure that tstate does not change between these calls, because we can see that some other parts of this code changes tstate

I also thought about it but ISTM that the following wouldn't make sense otherwise:

PyThreadState *tstate = _PyThreadState_GET();
...
if (_fill_sharedns(sharedns, nsupdates, fallback, &_err) < 0) {
    assert(_PyErr_Occurred(tstate));
    ...
}

But it's a good idea to use ifdefs just for that. We can also ask @ericsnowcurrently if our analysis is correct

I went with the safest bet: #ifndef NDEBUG