gh-65697: Improved error msg for configparser key validation #135527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
approved these changes
Jun 15, 2025
|
Nicely done. Thanks. |
|
Thanks @lincolnj1 for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 15, 2025
…ythonGH-135527) * Improved error msg for configparser key validation and added note in 3.14 whatsnew * Properly added change to configparser * 📜🤖 Added by blurb_it. --------- (cherry picked from commit 81237fb) Co-authored-by: Jacob Austin Lincoln <99031153+lincolnj1@users.noreply.github.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
|
GH-135541 is a backport of this pull request to the 3.14 branch. |
jaraco
pushed a commit
that referenced
this pull request
Jun 15, 2025
…H-135527) (#135541) gh-65697: Improved error msg for configparser key validation (GH-135527) * Improved error msg for configparser key validation and added note in 3.14 whatsnew * Properly added change to configparser * 📜🤖 Added by blurb_it. --------- (cherry picked from commit 81237fb) Co-authored-by: Jacob Austin Lincoln <99031153+lincolnj1@users.noreply.github.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
shuimu5418
pushed a commit
to shuimu5418/cpython001
that referenced
this pull request
Jun 16, 2025
…ython#135527) * Improved error msg for configparser key validation and added note in 3.14 whatsnew * Properly added change to configparser * 📜🤖 Added by blurb_it. --------- Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3.14, I updated the configparser to validate keys before writing them due to security concerns. As mentioned in recent discussion on gh-65697, this error message isn't terribly helpful and users didn't know that the change had been implemented at all. This change will let the user know which key (and potentially delimiter) caused an InvalidWriteError and also adds a note in the 3.14 whatsnew so that users will know about the previous change.