Skip to content

gh-111178: fix UBSan failures for RemoteUnwinderObject #135539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2025
Merged

gh-111178: fix UBSan failures for RemoteUnwinderObject #135539

merged 1 commit into from
Jun 15, 2025
+4 −1

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jun 15, 2025 •
edited by bedevere-app bot
Loading

This fixes the following

./python -m test test_external_inspection
...
Objects/object.c:3195:5: runtime error: call to function RemoteUnwinder_dealloc through pointer to incorrect function type 'void (*)(struct _object *)'
/home/picnix/lib/python/cpython/./Modules/_remote_debugging_module.c:2903: note: RemoteUnwinder_dealloc defined here

@picnixz picnixz requested review from pablogsal, ambv and 1st1 as code owners June 15, 2025 12:11
@bedevere-app bedevere-app bot mentioned this pull request Jun 15, 2025
Closed
@pablogsal pablogsal merged commit 54e29ea into python:main Jun 15, 2025
46 checks passed
@pablogsal
Copy link
Member

Thanks 🙏

@picnixz
Copy link
Member Author

picnixz commented Jun 15, 2025

You're welcome. We can backport this if you want but I don't know which versions are affected (I am not on my dev session)

@picnixz picnixz deleted the fix/ubsan/remote-inspection-111178 branch June 15, 2025 19:01
@pablogsal pablogsal added the needs backport to 3.14 bugs and security fixes label Jun 15, 2025
@miss-islington-app
Copy link

Thanks @picnixz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2025
@picnixz @miss-islington
pythongh-111178: fix UBSan failures for RemoteUnwinderObject (pytho…
414fc25 
…nGH-135539)

(cherry picked from commit 54e29ea)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@pablogsal
Copy link
Member

Yeah let's backport for sure

@bedevere-app
Copy link

bedevere-app bot commented Jun 15, 2025

GH-135547 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 15, 2025
pablogsal pushed a commit that referenced this pull request Jun 15, 2025
@miss-islington
[3.14] gh-111178: fix UBSan failures for RemoteUnwinderObject (GH-1…
e89c7f1 
…35539) (#135547)
shuimu5418 pushed a commit to shuimu5418/cpython001 that referenced this pull request Jun 16, 2025
@picnixz @shuimu5418
pythongh-111178: fix UBSan failures for RemoteUnwinderObject (pytho…
34e85c3 
…n#135539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@ambv ambv Awaiting requested review from ambv ambv is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picnixz @pablogsal