gh-135543: emit sys.remote_exec audit event when sys.remote_exec has been called
#135544
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c has been called Signed-off-by: Manjusaka <me@manjusaka.me>
pablogsal
reviewed
Jun 15, 2025
Lib/test/test_sys.py
Outdated
| @@ -2118,6 +2118,7 @@ def audit_hook(event, arg): | |||
| self.assertEqual(returncode, 0) | |||
| self.assertIn(b"Remote script executed successfully!", stdout) | |||
| self.assertIn(b"Audit event: remote_debugger_script, arg: ", stdout) | |||
| self.assertIn(b"Audit event: remote_exec, arg: ", stdout) | |||
There was a problem hiding this comment.
This is wrong this string will not appear in the remote it will appear in the process that executed remote_exec
Signed-off-by: Manjusaka <me@manjusaka.me>
sobolevn
reviewed
Jun 15, 2025
| def audit_hook(event, arg): | ||
| if event == "remote_exec": | ||
| nonlocal remote_exec_event_triggered | ||
| remote_exec_event_triggered = True |
There was a problem hiding this comment.
It would be better to save arg, not just True. And compare arg with the expected value.
vstinner
reviewed
Jun 16, 2025
| if event == "remote_exec": | ||
| nonlocal remote_exec_event_triggered | ||
| remote_exec_event_triggered = True | ||
| sys.addaudithook(audit_hook) |
There was a problem hiding this comment.
It's not possible to clear audit hooks, so move this test to test_audit which is designed for that: see Lib/test/audit-tests.py.
| @@ -1933,6 +1933,11 @@ always available. Unless explicitly noted otherwise, all variables are read-only | |||
| interpreter is pre-release (alpha, beta, or release candidate) then the | |||
| local and remote interpreters must be the same exact version. | |||
|
|
|||
| .. audit-event:: remove_exec pid script_path | |||
There was a problem hiding this comment.
Suggested change
| .. audit-event:: remove_exec pid script_path | |
| .. audit-event:: remote_exec pid script_path |
| .. audit-event:: remove_exec pid script_path | ||
|
|
||
| When the code is executed in the remote process, an :ref:`auditing event <auditing>` | ||
| ``remove_exec`` is raised with the *pid* and the path to the script file. |
There was a problem hiding this comment.
Suggested change
| ``remove_exec`` is raised with the *pid* and the path to the script file. | |
| ``remote_exec`` is raised with the *pid* and the path to the script file. |
Comment on lines
+1
to
+2
| emit ``sys.remote_exec`` audit event when ``sys.remote_exec`` has been | ||
| called |
There was a problem hiding this comment.
Suggested change
| emit ``sys.remote_exec`` audit event when ``sys.remote_exec`` has been | |
| called | |
| Emit ``remote_exec`` audit event when :func:`sys.remote_exec` is called. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #135543
sys.remote_exec()#135543📚 Documentation preview 📚: https://cpython-previews--135544.org.readthedocs.build/