Skip to content

gh-119132: Remove "experimental" tag from the CPython free-threading. #135550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 16, 2025
Merged

gh-119132: Remove "experimental" tag from the CPython free-threading. #135550

merged 14 commits into from
Jun 16, 2025

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jun 15, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 15, 2025
Closed
@corona10 corona10 added the needs backport to 3.14 bugs and security fixes label Jun 15, 2025
@hugovk
Copy link
Member

hugovk commented Jun 15, 2025

And remove from docs here:

cpython/Doc/howto/free-threading-python.rst

Lines 45 to 46 in 60181f4

To check if the current interpreter supports free-threading, :option:`python -VV <-V>`
and :data:`sys.version` contain "experimental free-threading build".

This should also have a What's New entry about the PEP. And NEWS as well?

corona10 and others added 2 commits June 16, 2025 07:17
@corona10 @hugovk
Address code review
1f4ec9d 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@corona10
Add NEWS.d
e668b84
@corona10
Copy link
Member Author

corona10 commented Jun 15, 2025 •
edited
Loading

And remove from docs here:

Nice catch, I also add you as co-authors.

@corona10 corona10 requested a review from hugovk June 15, 2025 22:21
@corona10
Copy link
Member Author

Also changing autoconf too.

@corona10 corona10 requested a review from erlend-aasland as a code owner June 15, 2025 22:27
@corona10 corona10 requested a review from a team as a code owner June 15, 2025 22:29
@corona10
Copy link
Member Author

corona10 commented Jun 15, 2025 •
edited
Loading

@hugovk https://docs.python.org/3.15/using/mac.html#installing-free-threaded-binaries

I think that we should update macOS installer and Windows installer too but I hope that it should be discussed with @ned-deily and @zooba

ZeroIntensity
ZeroIntensity reviewed Jun 15, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These cases also need to be changed:

cpython/Doc/using/mac.rst

Line 86 in 60181f4

To also install support for the optional experimental free-threaded feature,

cpython/Doc/using/mac.rst

Line 271 in 60181f4

Python |usemac_x_dot_y| that supports :pep:`703`, the experimental free-threading feature

cpython/Doc/library/ctypes.rst

Line 885 in 60181f4

In Python 3.13, the :term:`GIL` may be disabled on :term:`experimental free threaded <free threading>` builds.

cpython/Doc/using/windows.rst

Line 694 in 60181f4

Pre-built distributions of the experimental free-threaded build are available

@ZeroIntensity
Copy link
Member

I think that we should update macOS installer and Windows installer

Oh, oops, you beat me to it.

@ned-deily
Copy link
Member

@hugovk https://docs.python.org/3.15/using/mac.html#installing-free-threaded-binaries

I think that we should update macOS installer and Windows installer too but I hope that it should be discussed with @ned-deily and @zooba

I'm on it. I'll have the Mac installer and doc page updated for 3.14.0b3.

@corona10 corona10 requested a review from ZeroIntensity June 15, 2025 22:49
@corona10
Copy link
Member Author

readthedocs.org:

fatal: unable to access 'https://github.com/python/cpython.git/': The requested URL returned error: 500

@corona10 corona10 closed this Jun 16, 2025
@corona10 corona10 reopened this Jun 16, 2025
@Locked-chess-official Locked-chess-official mentioned this pull request Jun 16, 2025
Open
hugovk
hugovk reviewed Jun 16, 2025
View reviewed changes
@hugovk
Copy link
Member

hugovk commented Jun 16, 2025

This should also have a What's New entry about the PEP.

I've opened #135555 for this.

Yhg1s
Yhg1s reviewed Jun 16, 2025
View reviewed changes
corona10 and others added 2 commits June 16, 2025 22:08
@corona10 @Yhg1s
Update Doc/howto/free-threading-python.rst
b9df331 
Co-authored-by: T. Wouters <thomas@python.org>
@corona10 @Yhg1s @hugovk
Apply suggestions from code review
8655c6b 
Co-authored-by: T. Wouters <thomas@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@corona10 corona10 requested review from Yhg1s and hugovk June 16, 2025 13:51
hugovk
hugovk approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zooba
Copy link
Member

zooba commented Jun 16, 2025

The Windows installer undel Tools/msi is already deprecated, so let's just leave it.

If there are "experimental" tags anywhere in the PC/layout folder (particularly PC/layout/support/pymanager.py) then those should be updated to include version number checks to determine whether to include it or not (the scripts may be used to build/package older versions as well, where we want to keep the tag).

@hugovk
Copy link
Member

hugovk commented Jun 16, 2025

If there are "experimental" tags anywhere in the PC/layout folder [...]

None found 👍

@corona10 corona10 merged commit f079979 into python:main Jun 16, 2025
43 checks passed
@miss-islington-app
Copy link

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2025
@corona10 @hugovk
@ZeroIntensity @Yhg1s @miss-islington
pythongh-119132: Remove "experimental" tag from the CPython free-thre…
78e5a53 
…ading. (pythongh-135550)

* pythongh-119132: Remove "experimental" tag from the CPython free-threading build

* Address code review

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

* Add NEWS.d

* Regen configure.ac

* Update doc

* Update

* Update

* Update

* Update Doc/howto/free-threading-python.rst

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

* Update ctypes.rst

* Update

* Update Doc/howto/free-threading-python.rst

Co-authored-by: T. Wouters <thomas@python.org>

* Apply suggestions from code review

Co-authored-by: T. Wouters <thomas@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

---------
(cherry picked from commit f079979)

Co-authored-by: Donghee Na <donghee.na@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: T. Wouters <thomas@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Jun 16, 2025

GH-135565 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 16, 2025
corona10 added a commit that referenced this pull request Jun 16, 2025
@miss-islington @corona10
@hugovk @ZeroIntensity @Yhg1s
[3.14] gh-119132: Remove "experimental" tag from the CPython free-thr…
9410113 
…eading. (gh-135550) (gh-135565)

---------
(cherry picked from commit f079979)

Co-authored-by: Donghee Na <donghee.na@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: T. Wouters <thomas@python.org>
@ned-deily
Copy link
Member

I'm on it. I'll have the Mac installer and doc page updated for 3.14.0b3.

#135591 (main / 3.15)
#135594 (3.14)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity

@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Assignees

@hugovk hugovk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@corona10 @hugovk @ZeroIntensity @ned-deily @zooba @Yhg1s