bpo-37058: PEP 544: Add Protocol to typing module #13585
Conversation
|
|
||
| func(C()) # Passes static type check | ||
|
|
||
| See :pep:`544` for details. Protocol classes decorated with |
There was a problem hiding this comment.
This is okay for now, but at some point we may want to make it so that the docs are self-contained without any references to PEPs. (This is so that in the future the implementation can evolve, and the docs should describe the current implementation, while the PEP describes the implementation as it was at the time the PEP was finalized.)
There was a problem hiding this comment.
Yes, we can expand the docs later.
To be precise it is not literally a copy. I added some docstrings, few more comments, and factored-out couple pieces of code into private helpers. The tests however are 1:1 copied, so there are no semantic changes. |
|
@gvanrossum Thanks for review! (Also thank you for reviewing the other PEP PRs!) |
I tried to get rid of the `_ProtocolMeta`, but unfortunately it didn'y work. My idea to return a generic alias from `@runtime_checkable` made runtime protocols unpickleable. I am not sure what is worse (a custom metaclass or having some classes unpickleable), so I decided to stick with the status quo (since there were no complains so far). So essentially this is a copy of the implementation in `typing_extensions` with two modifications: * Rename `@runtime` to `@runtime_checkable` (plus corresponding updates). * Allow protocols that extend `collections.abc.Iterable` etc.
cc @ambv @JukkaL
I tried to get rid of the
_ProtocolMeta, but unfortunately it didn'y work. My idea to return a generic alias from@runtime_checkablemade runtime protocols unpickleable. I am not sure what is worse (a custom metaclass or having some classes unpickleable), so I decided to stick with the status quo (since there were no complains so far). So essentially this is a copy of the implementation intyping_extensionswith two modifications:@runtimeto@runtime_checkable(plus corresponding updates).collections.abc.Iterableetc.https://bugs.python.org/issue37058