gh-133125: Clarify ZipInfo.date_time attribute documentation #136082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f timestamp and limitations
|
This is how it looks like |
emmatyping
requested changes
Jul 23, 2025
There was a problem hiding this comment.
@KentaroJay thanks for the PR! Would you be interested in adding information about the way CPython interprets the timezone of the datetime (i.e. the time is interpreted as the local timezone). This was brought up in #123059.
I can do that in a follow up if you'd prefer to keep this focused on just covering the source of the timestamp information.
|
@emmatyping |
Co-authored-by: Emma Smith <emma@emmatyping.dev>
|
Hi @emmatyping ! |
emmatyping
approved these changes
Aug 2, 2025
Co-authored-by: Emma Smith <emma@emmatyping.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zipfile: docs should document whatZipInfo.date_timeactually is #133125📚 Documentation preview 📚: https://cpython-previews--136082.org.readthedocs.build/