Skip to content

gh-136306: Add support for SSL groups #136307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 28, 2025
Merged

gh-136306: Add support for SSL groups #136307

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
662d66e
gh-136306: Initial cut at SSL groups support
ronf Jul 4, 2025
9acb2c3
Fix regen and lint issues
ronf Jul 4, 2025
03072c4
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 4, 2025
187ff2e
gh-136306: Address first round of comments
ronf Jul 5, 2025
452bdec
gh-136306: Add back indentation of example
ronf Jul 5, 2025
9b4066b
gh-136306: Handle another allocation failure in get_groups()
ronf Jul 5, 2025
a6ad433
gh-136306: Address additional review comments
ronf Jul 5, 2025
aecc96b
gh-136306: Fix method references in whatsnew entry.
ronf Jul 5, 2025
05c75a5
gh-136306: Add missing documentation for SSLSocket.group()
ronf Jul 5, 2025
304c223
gh-136306: Address additional review comments
ronf Jul 6, 2025
b516200
gh-136306: Minor doc updates
ronf Jul 7, 2025
e0fdd25
gh-136306: Missed one
ronf Jul 7, 2025
35a3ae0
gh-136306: Address additional review comments
ronf Jul 12, 2025
e0baf56
Add checks that cipher() and group() return None on handshake failure
ronf Jul 12, 2025
c5a1146
Merge branch 'main' into ssl-group-support
ronf Jul 19, 2025
5e626a6
gh-136306: Regenerate clinic signature to fix missing end fo line
ronf Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-136306: Fix method references in whatsnew entry.
  • Loading branch information
@ronf
ronf committed Jul 5, 2025
commit aecc96bde66a6b49ce63aeb2980870419114dc5a
9 changes: 5 additions & 4 deletions Doc/whatsnew/3.15.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,16 +160,17 @@

* Added new methods for managing groups used for SSL key agreement

* :meth:`SSLContext.set_groups` sets the groups allowed for doing
key agreement, extending the previous :meth:`set_ecdh_curve` method.
* :meth:`ssl.SSLContext.set_groups` sets the groups allowed for doing
key agreement, extending the previous
:meth:`ssl.SSLContext.set_ecdh_curve` method.
This new API provides the ability to list multiple groups and
supports fixed-field and post-quantum groups in addition to ECDH
curves. This method can also be used to control what key shares
are sent in the TLS handshake.
* :meth:`SSLSocket.group` returns the group selected for doing key
* :meth:`ssl.SSLSocket.group` returns the group selected for doing key

Check warning on line 170 in Doc/whatsnew/3.15.rst

View workflow job for this annotation

GitHub Actions / Docs / Docs 

py:meth reference target not found: ssl.SSLSocket.group [ref.meth]
agreement on the current connection after the TLS handshake completes.
This call requires OpenSSL 3.2 or later.
* :meth:`SSLContext.get_groups` returns a list of all available key
* :meth:`ssl.SSLContext.get_groups` returns a list of all available key
agreement groups compatible with the minimum and maximum TLS versions
currently set in the context. This call requires OpenSSL 3.5 or later.

Expand Down
Loading