gh-74185: repr() of ImportError now contains attributes name and path #136770
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
You need to sign the CLA. Requesting @encukou who wanted to finish this per #1011 (comment) |
Misc/NEWS.d/next/Core_and_Builtins/2025-07-19-10-35-31.gh-issue-74185.7hPCA5.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This looks good now. I'll let @serhiy-storchaka have a look as well.
Misc/NEWS.d/next/Core_and_Builtins/2025-07-19-10-35-31.gh-issue-74185.7hPCA5.rst
Outdated
Show resolved
Hide resolved
thanks for the review @picnixz ! 🙏 |
Doc/whatsnew/3.15.rst
Outdated
| * The :meth:`~object.__repr__` of :class:`ImportError` and :class:`ModuleNotFoundError` | ||
| now shows "name" and "path" as ``name=<name>`` and ``path=<path>`` if they were given | ||
| as keyword arguments at construction time. | ||
| (Contributed by Serhiy Storchaka, Oleg Iarygin, and Yoav Nir in :gh:`74185`.) | ||
|
|
There was a problem hiding this comment.
Hey @Yoav11, there's a conflict with main in this place. It needs to be resolved.
There was a problem hiding this comment.
Sorry for ignoring this PR earlier. It did not looked important to me, and I was no longer sure about its usefulness, because path is usually so long.
Why use PyUnicodeWriter at first place? Does it make the code smaller/clearer? Is the performance difference too large?
| if (PyUnicodeWriter_WriteSubstring( | ||
| writer, r, 0, PyUnicode_GET_LENGTH(r) - 1) < 0) | ||
| { | ||
| Py_XDECREF(r); |
There was a problem hiding this comment.
| Py_XDECREF(r); | |
| Py_DECREF(r); |
| Py_XDECREF(r); | ||
| goto error; | ||
| } | ||
| Py_XDECREF(r); |
There was a problem hiding this comment.
| Py_XDECREF(r); | |
| Py_DECREF(r); |
| { | ||
| int hasargs = PyTuple_GET_SIZE(((PyBaseExceptionObject *)self)->args) != 0; | ||
| PyImportErrorObject *exc = PyImportErrorObject_CAST(self); | ||
| PyUnicodeWriter *writer = PyUnicodeWriter_Create(0); |
There was a problem hiding this comment.
If there are no name and path, it can just return the result of BaseException_repr(). There is no need to create a PyUnicodeWriter.
@picnixz recommended PyUnicodeWriter in #136770 (comment) |
|
What were the problems with recreating the strings? Do you have any benchmark data? |
|
@serhiy-storchaka, what would be your preferred alternative to PyUnicodeWriter? As far as I know, @vstinner added it exactly for use cases like this. |
|
The original PR used |
@serhiy-storchaka Please see a small benchmark test of the two alternatives here Yoav11#1 |
This PR was created during Europython 2025's sprint weekend.
This is a patch on #1011. authored by serhiy-storchaka and arhadthedev