Skip to content

Fix docs for Queue.shutdown #137028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 24, 2025
+58 −35
Merged

Fix docs for Queue.shutdown #137028

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
cfd65b8
Fix docs for Queue.shutdown
rhettinger Jul 23, 2025
dc762d7
Clarify adjustment to unfinished tasks
rhettinger Jul 23, 2025
4e132c4
Clarify that Queue.join is unblocked unconditionally
rhettinger Jul 23, 2025
5a93c53
Clarify "wound down"
rhettinger Jul 24, 2025
478cbab
Focus discussion on effects instead of process
rhettinger Jul 24, 2025
2c20579
Remove distraction about unblocking blocked gets for an empty queue
rhettinger Jul 24, 2025
4d14799
Update the docstring
rhettinger Jul 24, 2025
6740c3f
Update asyncio docstring
rhettinger Jul 24, 2025
af1744e
Update asynico main docs
rhettinger Jul 24, 2025
12d1ea9
Match the exception used by asyncio
rhettinger Jul 24, 2025
4620deb
Update task_done docstrings
rhettinger Jul 24, 2025
2ab910e
Fix word order
rhettinger Jul 24, 2025
7ad150b
Add missing subsection header
rhettinger Jul 24, 2025
7de4f73
Replace parenthetical with a prepositional phrase.
rhettinger Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update task_done docstrings
  • Loading branch information
@rhettinger
rhettinger committed Jul 24, 2025
commit 4620deb0e75d0088e87f7772e10bb2186a4c7b09
3 changes: 0 additions & 3 deletions Lib/asyncio/queues.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,6 @@ def task_done(self):
been processed (meaning that a task_done() call was received for every
item that had been put() into the queue).

shutdown(immediate=True) calls task_done() for each remaining item in
the queue.

Raises ValueError if called more times than there were items placed in
the queue.
"""
Expand Down
3 changes: 0 additions & 3 deletions Lib/queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ def task_done(self):
have been processed (meaning that a task_done() call was received
for every item that had been put() into the queue).

shutdown(immediate=True) calls task_done() for each remaining item in
the queue.

Raises a ValueError if called more times than there were items
placed in the queue.
'''
Expand Down
Loading