Skip to content

gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (take 2) #137047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 12, 2025
+117 −7
Merged

gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (take 2) #137047

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
916ce1b
gh-135228: When @dataclass(slots=True) replaces a dataclass, make the…
JelleZijlstra Jul 22, 2025
6dc0f48
Use a new private sys function instead
JelleZijlstra Jul 23, 2025
b9fb155
obsolete comment
JelleZijlstra Jul 23, 2025
52c7d2b
restrict to heap types
JelleZijlstra Jul 23, 2025
250f3e9
more paranoid
JelleZijlstra Jul 25, 2025
a9483b4
Apply suggestions from code review
JelleZijlstra Jul 29, 2025
8c2c1e1
Update Python/sysmodule.c
JelleZijlstra Jul 30, 2025
2d3bd7c
Feedback from Petr
JelleZijlstra Aug 5, 2025
06618d8
use AC for type checking
JelleZijlstra Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
obsolete comment
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Jul 23, 2025
commit b9fb155331c85efcaef5af24a98e4a571a7f71e3
1 change: 0 additions & 1 deletion Lib/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1339,7 +1339,6 @@ def _add_slots(cls, is_frozen, weakref_slot, defined_fields):
break

# gh-135228: Make sure the original class can be garbage collected.
# Bypass mapping proxy to allow __dict__ to be removed
sys._clear_type_descriptors(cls)

return newcls
Expand Down
Loading