Skip to content

gh-137242: Add Android CI job #137186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 12, 2025
+134 −23
Merged

gh-137242: Add Android CI job #137186

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
97ffb3e
Add Android CI job
mhsmith Jul 28, 2025
bd7b642
Add `shell` to each step of the composite action
mhsmith Jul 28, 2025
1d8dc2f
Use single quotes
mhsmith Jul 28, 2025
51ee923
Use different artifact names in each matrix job
mhsmith Jul 28, 2025
0d1b6d1
Use similar arguments to `--fast-ci`
mhsmith Jul 28, 2025
67c7af3
Suppress `make install` output by default
mhsmith Jul 30, 2025
16f1230
Strip debug information from release package by default
mhsmith Jul 30, 2025
563ca5a
Apply suggestions from code review
mhsmith Aug 3, 2025
bd876f4
Convert action into a single step with group markers
mhsmith Aug 3, 2025
6b9184c
Update zizmor
mhsmith Aug 3, 2025
55b91f7
Fix syntax
mhsmith Aug 3, 2025
56bed39
Cosmetic fixes
mhsmith Aug 4, 2025
f7f9f44
Update to NDK version 27.3.13750724
mhsmith Aug 6, 2025
4807047
Revert "Update zizmor"
mhsmith Aug 9, 2025
b3daf4b
Convert action into an `android.py ci` command
mhsmith Aug 9, 2025
c9700e4
Use `sudo` when updating udev rules
mhsmith Aug 9, 2025
e8e2a9e
Adjust matrix generation
mhsmith Aug 11, 2025
7e87375
Fix whitespace
mhsmith Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use sudo when updating udev rules
  • Loading branch information
@mhsmith
mhsmith committed Aug 9, 2025
commit c9700e47b6bf98f6ca2e60ecdbee15ba228dcc7c
17 changes: 7 additions & 10 deletions Android/android.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,10 @@ def clean_all(context):
def setup_ci():
# https://github.blog/changelog/2024-04-02-github-actions-hardware-accelerated-android-virtualization-now-available/
if "GITHUB_ACTIONS" in os.environ and platform.system() == "Linux":
Path("/etc/udev/rules.d/99-kvm4all.rules").write_text(
'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"\n'
run(
["sudo", "tee", "/etc/udev/rules.d/99-kvm4all.rules"],
input='KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"\n',
text=True,
)
run(["sudo", "udevadm", "control", "--reload-rules"])
run(["sudo", "udevadm", "trigger", "--name-match=kvm"])
Expand Down Expand Up @@ -691,13 +693,8 @@ def package(context):

# Strip debug information.
if not context.debug:
run(
[
android_env(context.host)["STRIP"],
*glob(f"{temp_dir}/**/*.so", recursive=True),
],
log=False,
)
so_files = glob(f"{temp_dir}/**/*.so", recursive=True)
run([android_env(context.host)["STRIP"], *so_files], log=False)

dist_dir = subdir(context.host, "dist", create=True)
package_path = shutil.make_archive(
Expand Down Expand Up @@ -731,7 +728,7 @@ def ci(context):
and (platform.system(), platform.machine()) != ("Linux", "x86_64")
):
print(
"Skipping test: GitHub Actions does not supports the Android "
"Skipping tests: GitHub Actions does not support the Android "
"emulator on this platform."
)
else:
Expand Down
Loading