Skip to content

gh-137200: support frame lineno setter with BRANCH_LEFT and BRANCH_RIGHT events #137229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 31, 2025
Merged

gh-137200: support frame lineno setter with BRANCH_LEFT and BRANCH_RIGHT events #137229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e8b3ec8
simple fix
xuantengh Jul 30, 2025
2e4db16
add test
xuantengh Jul 30, 2025
b49f95d
set lineno for frame 1
xuantengh Jul 31, 2025
d41cf78
Revert "set lineno for frame 1"
xuantengh Jul 31, 2025
b8e9f12
fix test
xuantengh Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Lib/test/test_monitoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import collections
import dis
import functools
import inspect
import math
import operator
import sys
Expand Down Expand Up @@ -1709,6 +1710,27 @@ def func(v=1):
('branch right', 'func', 6, 8),
('branch right', 'func', 2, 10)])

def test_callback_set_frame_lineno(self):
def func(s: str) -> int:
if s.startswith("t"):
return 1
else:
return 0

def callback(code, from_, to):
# try set frame.f_lineno
frame = inspect.currentframe()
while frame and frame.f_code is not code:
frame = frame.f_back

self.assertIsNotNone(frame)
frame.f_lineno = frame.f_lineno + 1 # run next instruction

sys.monitoring.set_local_events(TEST_TOOL, func.__code__, E.BRANCH_LEFT)
sys.monitoring.register_callback(TEST_TOOL, E.BRANCH_LEFT, callback)

self.assertEqual(func("true"), 1)


class TestBranchConsistency(MonitoringTestBase, unittest.TestCase):

Expand Down
2 changes: 2 additions & 0 deletions Objects/frameobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1685,6 +1685,8 @@ frame_lineno_set_impl(PyFrameObject *self, PyObject *value)
case PY_MONITORING_EVENT_PY_RESUME:
case PY_MONITORING_EVENT_JUMP:
case PY_MONITORING_EVENT_BRANCH:
case PY_MONITORING_EVENT_BRANCH_LEFT:
case PY_MONITORING_EVENT_BRANCH_RIGHT:
case PY_MONITORING_EVENT_LINE:
case PY_MONITORING_EVENT_PY_YIELD:
/* Setting f_lineno is allowed for the above events */
Expand Down
Loading