[3.14] gh-137288: Fix bug where boolean expressions are not associated with the correct exception handler (GH-137310). #137427
Conversation
…ociated with the correct exception handler (pythonGH-137310). (cherry picked from commit 1f2026b) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
Re-applying the blocker tag since the issue was closed. |
|
Oh. We will branch Fedora 43 tomorrow (which doubles the fun). We can handle this, it's just a tad tedious. @hugovk I'd appreciate some extra time for our rebuild, ideally by releasing rc2 with this fix sooner than planned and adding rc3 to the release schedule instead. Alternatively, we can backport this ourselves, but then our next build of rc1 gains a rc2-like magic number, which might be confusing. |
|
I've bumped the version in the test, and I've opened the discussion on I don't think this is worth spinning up the release machinery -- that's a lot of work for multiple people. If we want to avoid confusion for Fedora users, maybe skip rc2 (reserving it for rc1 with this patch), and release rc3 instead. (But I'm not sure what the impact of skipping a RC version is.) But, @hugovk, it would be good to merge this ASAP. |
|
Thanks Petr for approving this PR and opening the discussion. Let's merge this now. I'll have a think about doing an early rc2 and extra rc3, I'd prefer that over skipping an rc2. |
…ociated with the correct exception handler (pythonGH-137310). (python#137427) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
| @@ -278,6 +278,7 @@ Known values: | |||
| Python 3.14a7 3623 (Add BUILD_INTERPOLATION & BUILD_TEMPLATE opcodes) | |||
| Python 3.14b1 3624 (Don't optimize LOAD_FAST when local is killed by DELETE_FAST) | |||
| Python 3.14b3 3625 (Fix handling of opcodes that may leave operands on the stack when optimizing LOAD_FAST) | |||
| Python 3.14b5 3626 (Fix missing exception handlers in logical expression) | |||
There was a problem hiding this comment.
Thanks, I opened #137665 to also add the missing 3.14 numbers to main and then we can backport.
I am probably OK backporting this. No need for an actual release. |
(cherry picked from commit 1f2026b)