Skip to content

gh-106318: Add example for str.isalpha() #137557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

adorilson
Copy link
Contributor

@adorilson adorilson commented Aug 8, 2025

vstinner and others added 4 commits August 8, 2025 10:54
…#106335)

Remove private _PyThreadState and _PyInterpreterState C API
functions: move them to the internal C API (pycore_pystate.h and
pycore_interp.h). Don't export most of these functions anymore, but
still export functions used by tests.

Remove _PyThreadState_Prealloc() and _PyThreadState_Init() from the C
API, but keep it in the stable API.
This reverts commit ebfa093.
Comment on lines 1993 to 1996
For example::

..doctest::

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These conflict

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the missing space after .. ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can’t have both :: and the doctest. Look at what happens when you build it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got. Fixing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


See Unicode Properties section in :ref:`unicode-howto`.
Copy link
Member

@StanFromIreland StanFromIreland Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which section exactly are you referring to? The description already covers the properties. Idea: It could be shown in the example, e.g.:

>>> import unicodedata
... unicodedata.category('é') 
'Ll'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which section exactly are you referring to?

https://docs.python.org/3/howto/unicode.html#unicode-properties

I couldn't link to the subsection. Now I discovered that :ref: role links to a label in the form .. _my-reference-label:, not to reStructuredText sections.

So, now I intend to put (adding this label on the Unicode Properties section)

See :ref:`unicode-properties`

I think this is more valuable than the example you suggested and a good complement to the description.

Shall I go ahead with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is done. Here and on #137592.

Co-authored-by: Éric <merwok@netwok.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

Add examples to docs for str methods
4 participants