Skip to content

GH-132732: Use pure op machinery to optimize various instructions with _POP_TOP and _POP_TWO #137577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

GH-132732: Use pure op machinery to optimize various instructions with _POP_TOP and _POP_TWO #137577

wants to merge 16 commits into from

Conversation

savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented Aug 9, 2025 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Aug 9, 2025
Open
@savannahostrowski savannahostrowski changed the title GH-132732: Use pure op machinery to optimize various _POP_TOP and _POP_TWO relevant instructions GH-132732: Use pure op machinery to optimize various instructions with _POP_TOP and _POP_TWO Aug 9, 2025
brandtbucher
brandtbucher requested changes Aug 9, 2025
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool! Just a quick run-through for now:

@bedevere-app
Copy link

bedevere-app bot commented Aug 9, 2025

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Fidget-Spinner
Fidget-Spinner reviewed Aug 9, 2025
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, just one nit.

@savannahostrowski
Copy link
Member Author

@brandtbucher Do you want to take another look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher requested changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@savannahostrowski @Fidget-Spinner @brandtbucher