Skip to content

gh-137600: Promote ast node constructor deprecation warnings to errors #137601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+244 −452
Open

gh-137600: Promote ast node constructor deprecation warnings to errors #137601

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d834320
Promote deprecation warnings to errors
brianschubert Aug 9, 2025
de5564a
Remove obsolete checks for copy.replace support
brianschubert Aug 9, 2025
4f4466f
Add whatsnew and news entries
brianschubert Aug 9, 2025
de883a5
Fix lints
brianschubert Aug 9, 2025
39cdf20
Handle error, fix leaked ref
brianschubert Aug 10, 2025
1d3a3b5
Minor tidy
brianschubert Aug 10, 2025
c066338
Minor tidy
brianschubert Aug 10, 2025
48267a3
Switch to PyUnicodeWriter
brianschubert Aug 10, 2025
fa270ff
Misc updates from review
brianschubert Aug 10, 2025
606708a
Use fully qualified type names more consistently, more `msg =` in tests
brianschubert Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add whatsnew and news entries
  • Loading branch information
@brianschubert
brianschubert committed Aug 9, 2025
commit 4f4466f3ccabd103679439617782279109d22ef3
10 changes: 10 additions & 0 deletions Doc/whatsnew/3.15.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,16 @@ hashlib
Removed
=======

ast
---

* The constructors of node types in the :mod:`ast` module now raise a
:exc:`TypeError` when a required argument is omitted or when a
keyword-argument that does not map to a field on the AST node is passed.
These cases had previously raised a :exc:`DeprecationWarning` since Python 3.13.
(Contributed by Brian Schubert and Jelle Zijlstra in :gh:`137600` and :gh:`105858`.)


ctypes
------

Expand Down
5 changes: 5 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-08-09-19-00-36.gh-issue-137600.p_p6OU.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
The constructors of node types in the :mod:`ast` module now raise a
:exc:`TypeError` when a required argument is omitted or when a
keyword-argument that does not map to a field on the AST node is passed.
These cases had previously raised a :exc:`DeprecationWarning` since Python
3.13. Patch by Brian Schubert.
Loading