Skip to content

gh-73487: Convert _decimal to use Argument Clinic (part 1) #137606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+1,173 −266
Open

gh-73487: Convert _decimal to use Argument Clinic (part 1) #137606

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
439380e
gh-73487: convert the _decimal module to use AC
skirpichev Jul 12, 2025
ada9e7e
+1
skirpichev Aug 10, 2025
22eb776
+1
skirpichev Aug 10, 2025
b161565
Reduce docstring diff
AA-Turner Aug 10, 2025
2c53b48
Apply suggestions from code review
skirpichev Aug 11, 2025
354d8db
+1
skirpichev Aug 10, 2025
d78a97f
address review: move to_integral_value around
skirpichev Aug 11, 2025
81cba59
Revert "+1"
skirpichev Aug 11, 2025
8b757da
address review: rename some self
skirpichev Aug 11, 2025
306980a
address review: remove old doc_to_integral_value
skirpichev Aug 11, 2025
98b0e38
add news
skirpichev Aug 11, 2025
5d9911a
Merge branch 'master' into ac-decimal/73487
skirpichev Aug 12, 2025
15860bd
drop redundant comments
skirpichev Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
drop redundant comments
  • Loading branch information
@skirpichev
skirpichev committed Aug 12, 2025
commit 15860bd1baf7a3e9cd322cd80b28b120ea20b8fc
8 changes: 0 additions & 8 deletions Modules/_decimal/_decimal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2877,8 +2877,6 @@ PyDecType_FromSequenceExact(PyTypeObject *type, PyObject *v,
#define PyDec_FromSequenceExact(st, sequence, context) \
PyDecType_FromSequenceExact((st)->PyDec_Type, sequence, context)

/* class method */

/*[clinic input]
@classmethod
_decimal.Decimal.from_float
Expand Down Expand Up @@ -2947,8 +2945,6 @@ PyDecType_FromNumberExact(PyTypeObject *type, PyObject *v, PyObject *context)
}
}

/* class method */

/*[clinic input]
@classmethod
_decimal.Decimal.from_number
Expand Down Expand Up @@ -3803,8 +3799,6 @@ dec_as_long(PyObject *dec, PyObject *context, int round)
return PyLongWriter_Finish(writer);
}

/* Convert a Decimal to its exact integer ratio representation. */

/*[clinic input]
_decimal.Decimal.as_integer_ratio

Expand Down Expand Up @@ -4120,8 +4114,6 @@ PyDec_Round(PyObject *dec, PyObject *args)
}
}

/* Return the DecimalTuple representation of a PyDecObject. */

/*[clinic input]
_decimal.Decimal.as_tuple

Expand Down
Loading