Skip to content

gh-73487: Convert _decimal to use Argument Clinic (part 2) #137637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
+7,716 −1,449
Draft

gh-73487: Convert _decimal to use Argument Clinic (part 2) #137637

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
439380e
gh-73487: convert the _decimal module to use AC
skirpichev Jul 12, 2025
ada9e7e
+1
skirpichev Aug 10, 2025
22eb776
+1
skirpichev Aug 10, 2025
b161565
Reduce docstring diff
AA-Turner Aug 10, 2025
2c53b48
Apply suggestions from code review
skirpichev Aug 11, 2025
354d8db
+1
skirpichev Aug 10, 2025
d78a97f
address review: move to_integral_value around
skirpichev Aug 11, 2025
81cba59
Revert "+1"
skirpichev Aug 11, 2025
8b757da
address review: rename some self
skirpichev Aug 11, 2025
306980a
address review: remove old doc_to_integral_value
skirpichev Aug 11, 2025
98b0e38
add news
skirpichev Aug 11, 2025
fe48aa0
+1
skirpichev Aug 10, 2025
9c53067
+1
skirpichev Aug 11, 2025
56de9bb
+ regen-all
skirpichev Aug 11, 2025
257c4fa
Merge branch 'master' into ac-decimal/73487-pt2
skirpichev Aug 11, 2025
d0b03ff
+ convert functions
skirpichev Aug 12, 2025
9c9ec72
start Context class...
skirpichev Aug 12, 2025
30abd3a
drop redundant comments
skirpichev Aug 12, 2025
43a9798
+1 // more unary
skirpichev Aug 12, 2025
11bef22
- more comments
skirpichev Aug 12, 2025
b80b4ed
+ most binary
skirpichev Aug 12, 2025
10fe41b
+1
skirpichev Aug 12, 2025
5b69d94
remove Modules/_decimal/docstrings.h
skirpichev Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
  • Loading branch information
@skirpichev @AA-Turner
skirpichev and AA-Turner authored Aug 11, 2025
commit 2c53b4869eb194378346f2de26fd2d079076e7fc
6 changes: 4 additions & 2 deletions Modules/_decimal/_decimal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2912,7 +2912,8 @@ _decimal_Decimal_from_float_impl(PyTypeObject *type, PyObject *pyfloat)
CURRENT_CONTEXT(state, context);
result = PyDecType_FromFloatExact(state->PyDec_Type, pyfloat, context);
if (type != state->PyDec_Type && result != NULL) {
Py_SETREF(result, PyObject_CallFunctionObjArgs((PyObject *)type, result, NULL));
Py_SETREF(result,
PyObject_CallFunctionObjArgs((PyObject *)type, result, NULL));
}

return result;
Expand Down Expand Up @@ -2976,7 +2977,8 @@ _decimal_Decimal_from_number_impl(PyTypeObject *type, PyObject *number)
CURRENT_CONTEXT(state, context);
result = PyDecType_FromNumberExact(state->PyDec_Type, number, context);
if (type != state->PyDec_Type && result != NULL) {
Py_SETREF(result, PyObject_CallFunctionObjArgs((PyObject *)type, result, NULL));
Py_SETREF(result,
PyObject_CallFunctionObjArgs((PyObject *)type, result, NULL));
}

return result;
Expand Down
Loading