[3.14] GH-137426: Remove code deprecation of importlib.abc.ResourceLoader (GH-137567)
#137654
+12
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader` (pythonGH-137567) Enough other classes in `importlib.abc` inherit from the class and the deprecation was to redirect people to `TraversableResources`. The documentation now makes it clear the class only exists for backwards compatibility. --------- (cherry picked from commit 7140b99) Co-authored-by: Brett Cannon <brett@python.org> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This was referenced Aug 11, 2025
importlib.abc.SourceLoader issues DeprecationWarning because it inherits from ResourceLoader
#137426
Closed
brettcannon
approved these changes
Aug 11, 2025
|
@hugovk adding you for cherrypicking into 3.14.0rc2 . |
hugovk
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enough other classes in
importlib.abcinherit from the class and the deprecation was to redirect people toTraversableResources. The documentation now makes it clear the class only exists for backwards compatibility.(cherry picked from commit 7140b99)
Co-authored-by: Brett Cannon brett@python.org
Co-authored-by: Hugo van Kemenade 1324225+hugovk@users.noreply.github.com
importlib.abc.SourceLoaderissuesDeprecationWarningbecause it inherits fromResourceLoader#137426📚 Documentation preview 📚: https://cpython-previews--137654.org.readthedocs.build/