Skip to content

GH-137573: Check C stack depth before stack allocating JIT optimizer struct #137676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

GH-137573: Check C stack depth before stack allocating JIT optimizer struct #137676

wants to merge 2 commits into from
+40 −1

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Aug 12, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Aug 12, 2025
Open
AA-Turner
AA-Turner reviewed Aug 12, 2025
View reviewed changes
Lib/test/test_call.py
@@ -1075,6 +1075,7 @@ def c_py_recurse(m):
c_py_recurse(100_000)



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated?

Suggested change

@Fidget-Spinner
Copy link
Member

Just so I'm clear: you plan to move this to the thread state later but only on main right? So that we don't change the struct layout in an rc for 3.14?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner left review comments

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner

Assignees

@Fidget-Spinner Fidget-Spinner

Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markshannon @Fidget-Spinner @AA-Turner