-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
GH-137630: Convert _interpqueues
to use Argument Clinic
#137685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bug in the current code which should be fixed in 3.14 too. The rest LGTM. But I would like to get @ericsnowcurrently's approve.
@@ -0,0 +1,2 @@ | |||
The :mod:`!_interpqueues` module now uses Argument Clinic to parse arguments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually do not add NEWS files for conversions to Argument Clinic. Argument Clinic is an implementation detail.
I also add that after removing the return pseudo-annotation, some docstrings look more self-contadicting.
It was in the old docstrings, but with |
Note, we use a custom converter
qidarg_converter
here. I have changed theqidarg_converter()
function to simplify the return -- we only ever useqidarg.id
.pydoc diff:
A
_interpreters
to Argument Clinic #137630