Skip to content

[3.14] gh-137400: Fix thread-safety issues when profiling all threads (gh-137518) #137730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 3.14
Choose a base branch
from
Open

[3.14] gh-137400: Fix thread-safety issues when profiling all threads (gh-137518) #137730

wants to merge 2 commits into from
+430 −243

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Aug 13, 2025 •
edited by bedevere-app bot
Loading

There were a few thread-safety issues when profiling or tracing all threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:

  • The loop over thread states could crash if a thread exits concurrently (in both the free threading and default build)
  • The modification of c_profilefunc and c_tracefunc wasn't thread-safe on the free threading build.

(cherry picked from commit a10152f)

@colesbury
[3.14] pythongh-137400: Fix thread-safety issues when profiling all t…
a4b3a4b 
…hreads (pythongh-137518)

There were a few thread-safety issues when profiling or tracing all
threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:

* The loop over thread states could crash if a thread exits concurrently
  (in both the free threading and default build)
* The modification of `c_profilefunc` and `c_tracefunc` wasn't
  thread-safe on the free threading build.
(cherry picked from commit a10152f)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@colesbury colesbury self-assigned this Aug 13, 2025
This was referenced Aug 13, 2025
Open
Merged
@colesbury
Copy link
Contributor Author

This can wait until 3.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@colesbury colesbury

Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@colesbury