gh-137740: Clarify __del__ invocation mechanism in reference counting #137741
Conversation
|
All commit authors signed the Contributor License Agreement. |
There was a problem hiding this comment.
Thanks for contributing, but I've been working on upstreaming this tutorial to replace this part of the documentation. We can go through the effort of reviewing and landing this if you want, but keep in mind that it will likely be lost soon anyway.
Doc/extending/extending.rst
Outdated
| which invokes the object's ``tp_dealloc`` function (``subtype_dealloc`` for Python | ||
| class instances). During deallocation, ``subtype_dealloc`` calls ``tp_finalize``, | ||
| which is mapped to the ``__del__`` method for Python classes (see :pep:`442`). |
There was a problem hiding this comment.
We need to use Sphinx references to link to the members here.
There was a problem hiding this comment.
I have added references, to the best of my knowledge. Regardless of them being obsolete, I would really appreciate it to go through review process if possible, and get some feedbacks. They would help broaden my understanding, and I want to keep on supporting this project in ways I can.
Additionally, in your new tutorial, would it be possible to at keep something like this (thin ice) part. Normally, rigid examples like this gives an alternative perspective to understand things better, especially, for folks like me, new to cpython internals world.
There was a problem hiding this comment.
I'll see if there's a place to work it in, but the idea is to completely change how we explain reference counting.
Normally, rigid examples like this gives an alternative perspective to understand things better, especially, for folks like me, new to cpython internals world.
Yeah, I agree, that's why we're going to drop this section and use a tutorial that's been battle-tested.
| disposing of it will call its :meth:`!__del__` method. | ||
| disposing of it will call its :meth:`!__del__` method. Internally, | ||
| :c:func:`PyList_SetItem` calls :c:func:`Py_DECREF` on the replaced item, | ||
| which invokes replaced item's corrresponding |
There was a problem hiding this comment.
Typo:
| which invokes replaced item's corrresponding | |
| which invokes replaced item's corresponding |
Issue : gh-137740: Clarify reference counting details in "Thin Ice" section in
extendingdocumentation📚 Documentation preview 📚: https://cpython-previews--137741.org.readthedocs.build/