gh-131178: Fix test_unknown_flag for platform CLI
#137816
Open
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
cc @AA-Turner Bénédikt suggested ping you for this PR, could you review? |
AA-Turner
approved these changes
Aug 16, 2025
AA-Turner
reviewed
Aug 16, 2025
Comment on lines
768
to
-771
| with self.assertRaises(SystemExit): | ||
| output = io.StringIO() | ||
| # suppress argparse error message | ||
| with contextlib.redirect_stderr(output): | ||
| _ = self.invoke_platform('--unknown') | ||
| self.assertStartsWith(output, "usage: ") |
There was a problem hiding this comment.
The relevant issue is that self.assertStartsWith will ordinarily never be called due to the SystemExit.
@donBarbos in the future, please explain and provide context for your PRs, rather than just saying 'fix' -- assume reviewers are looking at your proposed changes with no prior context.
A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.