Skip to content

Emend an error in string.templatelib example output #137890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2025
Merged

Emend an error in string.templatelib example output #137890

merged 1 commit into from
Aug 17, 2025

Conversation

wiomoc
Copy link
Contributor

@wiomoc wiomoc commented Aug 17, 2025 •
edited by github-actions bot
Loading

Fixes a subtle typo in templatelib documentation

📚 Documentation preview 📚: https://cpython-previews--137890.org.readthedocs.build/

@python-cla-bot
Copy link

python-cla-bot bot commented Aug 17, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Aug 17, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Aug 17, 2025
sharktide
sharktide reviewed Aug 17, 2025
View reviewed changes
@sharktide

This comment has been minimized.

Sign in to view
@AA-Turner
Copy link
Member

fun with labels @ZeroIntensity!

@AA-Turner
Copy link
Member

Odd that this wasn't caught by doctest, though.

@AA-Turner AA-Turner changed the title Fix typo in string templatelib doc Emend an error in string.templatelib example output Aug 17, 2025
@sharktide
Copy link
Contributor

sharktide commented Aug 17, 2025 •
edited
Loading

Sheesh. 3 approvals in less than than an hour. I've rarely seen that

:)

@AA-Turner AA-Turner merged commit 8e3244d into python:main Aug 17, 2025
54 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Aug 17, 2025
@miss-islington-app
Copy link

Thanks @wiomoc for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 17, 2025
@wiomoc @miss-islington
Emend an error in string.templatelib example output (pythonGH-137890
864b07c 
)

(cherry picked from commit 8e3244d)

Co-authored-by: Christoph Walcher <christoph-wa@gmx.de>
@bedevere-app
Copy link

bedevere-app bot commented Aug 17, 2025

GH-137892 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 17, 2025
@ZeroIntensity
Copy link
Member

fun with labels @ZeroIntensity!

The stupid label interface undoes the bot's changes if I do it too quickly

@sharktide
Copy link
Contributor

fun with labels @ZeroIntensity!

The stupid label interface undoes the bot's changes if I do it too quickly

Yeah we need to try to improve bedevere. Not just this which I suspect is GitHub's issue but here's a load more of issues I haven't uploaded to the issue tracker yet or discourse

@ZeroIntensity
Copy link
Member

Be the PR you want to see in the world: https://github.com/python/bedevere

hugovk pushed a commit that referenced this pull request Aug 18, 2025
@miss-islington @wiomoc
[3.14] Emend an error in string.templatelib example output (GH-13…
c9e2e15 
…7890) (#137892)

Emend an error in ``string.templatelib`` example output (GH-137890)
(cherry picked from commit 8e3244d)

Co-authored-by: Christoph Walcher <christoph-wa@gmx.de>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@wiomoc @Agent-Hellboy
Emend an error in string.templatelib example output (python#137890)
e404cd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

+1 more reviewer

@sharktide sharktide sharktide approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wiomoc @sharktide @AA-Turner @ZeroIntensity