gh-114576: Add command-line interface for dbm module #137893
Conversation
|
|
||
|
|
||
| .. _dbm-commandline: | ||
| .. program:: dbm |
There was a problem hiding this comment.
.. program:: directive should be placed closer to options
| .. program:: dbm |
|
|
||
| .. option:: --whichdb file [file ...] |
There was a problem hiding this comment.
see above
| .. option:: --whichdb file [file ...] | |
| .. program:: dbm | |
| .. option:: --whichdb file [file ...] |
|
|
||
| .. option:: -h, --help | ||
|
|
||
| Show the help message. |
There was a problem hiding this comment.
I'm not sure we should add help flag as option because it's not a common practice.
| .. option:: -h, --help | |
| Show the help message. |
Lib/dbm/__main__.py
Outdated
| for filename in filenames: | ||
| if os.path.exists(filename): | ||
| db_type = whichdb(filename) | ||
| print(f"{db_type or 'UNKNOWN'} - {filename}") |
There was a problem hiding this comment.
A hyphen is not needed.
Lib/dbm/__main__.py
Outdated
| def _dump_command(filename): | ||
| try: | ||
| with dbm_open(filename, "r") as db: | ||
| for key in db.keys(): |
There was a problem hiding this comment.
Don't use keys(), it reads all keys in memory. Use iteration.
Lib/dbm/__main__.py
Outdated
| key_str = key.decode("utf-8", errors="replace") | ||
| value_str = db[key].decode("utf-8", errors="replace") |
There was a problem hiding this comment.
Keys and values are bytes. Such decoding may result in loss of information.
How to output bytes without loss? One way to use repr() (not very readable for non-ASCII text). Other way to write to sys.stdout.buffer (this will not work on Windows with not redirected stdout). There are other ways, this should be considered together with the problem of separators (see below).
| group = parser.add_mutually_exclusive_group(required=True) | ||
| group.add_argument( | ||
| "--whichdb", |
There was a problem hiding this comment.
Instead of options, why not use subparsers for subcommands?
There was a problem hiding this comment.
I chose not to include it to maintain clarity and simplicity, but I’m happy to add it if needed.
Lib/dbm/__init__.py::__main__as a script #114576📚 Documentation preview 📚: https://cpython-previews--137893.org.readthedocs.build/