Skip to content

gh-73487: Convert _decimal to use Argument Clinic (part 5) #137948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Aug 19, 2025

@skirpichev skirpichev force-pushed the ac-decimal/73487-pt5 branch from 2cb6b67 to f1ee85f Compare August 20, 2025 09:44
@@ -923,14 +923,34 @@ context_getallcr(PyObject *self, void *Py_UNUSED(closure))
}
#endif

/*[clinic input]
_decimal.Context.Etiny
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not merge this with part 4?

@@ -3149,21 +3169,29 @@ PyDec_FromObject(PyObject *v, PyObject *context)
}
}

/*[clinic input]
@classmethod
_decimal.Decimal.__new__ as dec_new
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't it in part 4?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this branch includes the changes from pt4, GH is bad at 'stacked' changes like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants