gh-137986: Fix csv.register_dialect docstring
#137949
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Aug 20, 2025
The csv.register_dialect() docstring no longer imply that it returns a dialect. All functions have now signatures.
csv.register_dialect docstringcsv.register_dialect docstring
|
I'm going to put it under gh-137986, we'll decide whether we want this change merged separately or not. |
|
Actually, this change is superseded by #137987 so I'm closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current docstring:
cpython/Modules/_csv.c
Line 1738 in 719e5c3
is incorrect, since the function does not return the dialect:
cpython/Modules/_csv.c
Line 1610 in 719e5c3
This is a public method:
I'm not sure if it warrants a
NEWS.dentry.