Skip to content

gh-137964: Remove the "experimental" designation from the Windows installer #137965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025

Conversation

itamaro
Copy link
Contributor

@itamaro itamaro commented Aug 19, 2025

Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense

@zooba
Copy link
Member

zooba commented Aug 19, 2025

We should still discourage this option, as it creates the mixed install directory that was the source of a range of issues for free-threaded users. But there's no risk in changing this string (and the entire installer shows that it's "deprecated").

Are there any references under PC\layout (probably support\pymanager.py in that directory)?

@zooba
Copy link
Member

zooba commented Aug 19, 2025

Just looked and confirmed there isn't, so this is okay to merge. @itamaro, will you coordinate the backport for 3.14?

@zooba zooba merged commit d22a745 into python:main Aug 19, 2025
54 checks passed
@miss-islington-app
Copy link

Thanks @itamaro for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 19, 2025
…ws installer (pythonGH-137965)

(cherry picked from commit d22a745)

Co-authored-by: Itamar Oren <itamarost@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 19, 2025

GH-137971 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 19, 2025
@itamaro
Copy link
Contributor Author

itamaro commented Aug 19, 2025

thanks @zooba !

We should still discourage this option, as it creates the mixed install directory that was the source of a range of issues for free-threaded users

do we have a better solution for free-threaded users? is it any different when using pymanager? (is there another issue where this is being discussed?)

will you coordinate the backport for 3.14?

sure, thanks for merging!

@zooba
Copy link
Member

zooba commented Aug 19, 2025

do we have a better solution for free-threaded users? is it any different when using pymanager?

Yeah, the install manager will install a complete runtime (under a different prefix). I don't remember right now if it provides a python.exe or only a python3.Xt.exe (as decreed by the SC), but it definitely doesn't have a modified pyconfig.h (which was the cause of most of the issues).

So it's a bit better in terms of global package installation.

is there another issue where this is being discussed?

Not that I'm aware of, it came up on a few other issues when free-htreading stuff broke regular users. Anything specific to the install manager can be discussed on the pymanager repo.

hugovk pushed a commit that referenced this pull request Aug 20, 2025
…ows installer (GH-137965) (#137971)

Co-authored-by: Itamar Oren <itamarost@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants