gh-137976: Exclude symlinks from zoneinfo.available_timezones() results #137977
+27
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts\n\nSometimes available_timezones() was including 'localtime' in its results\nbecause it wasn't properly handling symlinks. This change ensures that\nsymlinks like 'localtime' are excluded from the available timezones list,\nproviding consistent results across different systems.\n\nAdded a test case to verify that symlinks are properly excluded.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
…ts\n\nSometimes available_timezones() was including 'localtime' in its results\nbecause it wasn't properly handling symlinks. This change ensures that\nsymlinks like 'localtime' are excluded from the available timezones list,\nproviding consistent results across different systems.\n\nAdded a test case to verify that symlinks are properly excluded.
|
This would remove many valid timezones, including "GMT" and "UTC". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes available_timezones() was including 'localtime' in its results because it wasn't properly handling symlinks.
This change ensures that symlinks like 'localtime' are excluded from the available timezones list, providing consistent results across different systems.
Added a test case to verify that symlinks are properly excluded.