Skip to content

cross port importlib-metadata PR #76 #13903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jun 7, 2019

@asottile
Copy link
Contributor Author

asottile commented Jun 7, 2019

(needs backport to 3.8 only)

@warsaw
Copy link
Member

warsaw commented Jun 7, 2019

@Mariatta Interesting buglet: If I add two labels at the same time (i.e. skip-news and skip-issue), it seems like the bot only gets one of them. I had to unapply skip-news and then reapply it.

@Mariatta
Copy link
Member

Mariatta commented Jun 7, 2019

Hmm this might be a GitHub related issue, a race condition of some sort..

@warsaw warsaw merged commit 65e5860 into python:master Jun 7, 2019
@bedevere-bot
Copy link

@warsaw: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @asottile for the PR, and @warsaw for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@warsaw
Copy link
Member

warsaw commented Jun 7, 2019

Hmm this might be a GitHub related issue, a race condition of some sort..

Yeah, probably

@bedevere-bot
Copy link

GH-13904 is a backport of this pull request to the 3.8 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants