Skip to content

bpo-37363: Add audit events for a range of modules #14301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 24, 2019
Merged

bpo-37363: Add audit events for a range of modules #14301

merged 5 commits into from
Jun 24, 2019

Conversation

zooba
Copy link
Member

@zooba zooba commented Jun 21, 2019 •
edited by bedevere-bot
Loading

Also fixes some documentation issues.

https://bugs.python.org/issue37363

@zooba zooba requested a review from tiran June 21, 2019 23:13
@zooba zooba requested review from gpshead and a team as code owners June 21, 2019 23:13
@zooba zooba requested a review from berkerpeksag as a code owner June 22, 2019 21:32
@zooba zooba merged commit 60419a7 into python:master Jun 24, 2019
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2019
@zooba @miss-islington
bpo-37363: Add audit events for a range of modules (pythonGH-14301)
f1c5994 
(cherry picked from commit 60419a7)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

GH-14345 is a backport of this pull request to the 3.8 branch.

@zooba zooba deleted the bpo-37363 branch June 24, 2019 15:43
miss-islington added a commit that referenced this pull request Jun 24, 2019
@miss-islington @zooba
bpo-37363: Add audit events for a range of modules (GH-14301)
8763d43 
(cherry picked from commit 60419a7)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.x has failed when building commit 60419a7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/103/builds/2698) and take a look at the build logs.
  4. Check if the failure is related to this commit (60419a7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/103/builds/2698

Click to see traceback logs 
From https://github.com/python/cpython
 * branch                  master     -> FETCH_HEAD
Reset branch 'master'

Objects/unicodeobject.c: In function ‘_PyUnicode_CheckConsistency’:
Objects/unicodeobject.c:461:15: warning: variable ‘data’ set but not used [-Wunused-but-set-variable]
         void *data;
               ^~~~
Python/peephole.c: In function ‘PyCode_Optimize’:
Python/peephole.c:258:19: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘Py_ssize_t’ {aka ‘int’} [-Wsign-compare]
     for (j = 0; j < tabsiz; j += 2) {
                   ^
Python/pystrhex.c: In function ‘_Py_strhex_impl’:
Python/pystrhex.c:60:27: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘Py_ssize_t’ {aka ‘const int’} [-Wsign-compare]
     if (abs_bytes_per_sep >= arglen) {
                           ^~

/buildbot/tmp/tmpdir/tmp5cgs1f1x/pip-19.0.3-py2.py3-none-any.whl/pip/_vendor/pyparsing.py:3068: SyntaxWarning: invalid escape sequence \w
/buildbot/tmp/tmpdir/tmp5cgs1f1x/pip-19.0.3-py2.py3-none-any.whl/pip/_vendor/pyparsing.py:3068: SyntaxWarning: invalid escape sequence \w

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@zooba @lisroach
bpo-37363: Add audit events for a range of modules (pythonGH-14301)
a17d2e4
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@zooba @DinoV
bpo-37363: Add audit events for a range of modules (pythonGH-14301)
c217726
@erlend-aasland erlend-aasland mentioned this pull request Apr 20, 2021
Merged
@zooba zooba mentioned this pull request Nov 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran Awaiting requested review from tiran

@gpshead gpshead Awaiting requested review from gpshead

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zooba @miss-islington @bedevere-bot @the-knights-who-say-ni