bpo-37571: Add 'b' to prevent the TypeError exception. #14721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeros
approved these changes
Jul 12, 2019
aeros
reviewed
Jul 12, 2019
Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
|
You're right. Thanks a lot for reviewing this. |
|
Thanks @mangrisano for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 14, 2019
Co-Authored-By: Kyle Stanley <aeros167@gmail.com> (cherry picked from commit 6b92958) Co-authored-by: Michele Angrisano <michele.angrisano@gmail.com>
|
GH-14762 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 14, 2019
Co-Authored-By: Kyle Stanley <aeros167@gmail.com> (cherry picked from commit 6b92958) Co-authored-by: Michele Angrisano <michele.angrisano@gmail.com>
|
GH-14763 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Jul 14, 2019
miss-islington
added a commit
that referenced
this pull request
Jul 14, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python3 is not be able to assign a str to a c_char_p, so the 'b' is essential to prevent the TypeError exception.
https://bugs.python.org/issue37571