bpo-36261: email example was misusing preamble field #14751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeros
approved these changes
Jul 13, 2019
There was a problem hiding this comment.
Thanks for the contribution. This correctly addresses the issue described and for consistency, using the same preamble found in email-dir.py.
However, since this format is exactly the same, I wonder if it would better to create a pre-configured setup to use as part of the EmailMessage class (as a private method) instead of replicating these 5 lines in different locations:
msg = EmailMessage()
msg['Subject'] = 'Contents of directory %s' % os.path.abspath(directory)
msg['To'] = ', '.join(args.recipients)
msg['From'] = args.sender
msg.preamble = 'You will not see this in a MIME-aware mail reader.\n'|
Thanks @carlbordum for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 14, 2019
…nGH-14751) (cherry picked from commit 8efade9) Co-authored-by: Carl Bordum Hansen <carl@bordum.dk>
|
GH-14760 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 14, 2019
…nGH-14751) (cherry picked from commit 8efade9) Co-authored-by: Carl Bordum Hansen <carl@bordum.dk>
|
GH-14761 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Jul 14, 2019
) (cherry picked from commit 8efade9) Co-authored-by: Carl Bordum Hansen <carl@bordum.dk>
miss-islington
added a commit
that referenced
this pull request
Jul 14, 2019
) (cherry picked from commit 8efade9) Co-authored-by: Carl Bordum Hansen <carl@bordum.dk>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36261