Skip to content

[3.7] bpo-37461: Fix infinite loop in parsing of specially crafted email headers (GH-14794) #14816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 17, 2019

  • bpo-37461: Fix infinite loop in parsing of specially crafted email headers.

Some crafted email header would cause the get_parameter method to run in an
infinite loop causing a DoS attack surface when parsing those headers. This
patch fixes that by making sure the DQUOTE character is handled to prevent
going into an infinite loop.
(cherry picked from commit a4a994b)

Co-authored-by: Abhilash Raj maxking@users.noreply.github.com

https://bugs.python.org/issue37461

…aders (pythonGH-14794)

* bpo-37461: Fix infinite loop in parsing of specially crafted email headers.

Some crafted email header would cause the get_parameter method to run in an
infinite loop causing a DoS attack surface when parsing those headers. This
patch fixes that by making sure the DQUOTE character is handled to prevent
going into an infinite loop.
(cherry picked from commit a4a994b)

Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
@miss-islington
Copy link
Contributor Author

@maxking and @warsaw: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 391511c into python:3.7 Jul 17, 2019
@miss-islington miss-islington deleted the backport-a4a994b-3.7 branch July 17, 2019 17:02
@miss-islington
Copy link
Contributor Author

@maxking and @warsaw: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-security A security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants